Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed schema.fieldsMatch #981

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Fixed schema.fieldsMatch #981

merged 2 commits into from
Sep 25, 2024

Conversation

roll
Copy link
Member

@roll roll commented Sep 24, 2024 •
edited
Loading

@roll roll force-pushed the 975/fix-schema-fields-match branch from 777d448 to a2560aa Compare September 24, 2024 13:05
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024 •
edited
Loading

Deploying datapackage with  Cloudflare Pages  Cloudflare Pages

Latest commit: db5f8be
Status: ✅  Deploy successful!
Preview URL: https://8678c9e2.datapackage-6gp.pages.dev
Branch Preview URL: https://975-fix-schema-fields-match.datapackage-6gp.pages.dev

View logs

@roll roll requested a review from peterdesmet September 24, 2024 13:06
@roll roll force-pushed the 975/fix-schema-fields-match branch from a2560aa to e20ac0e Compare September 24, 2024 13:28
peterdesmet
peterdesmet approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@peterdesmet peterdesmet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have updated the phrasing in Changelog. I don't understand why fieldsMatch appears in 2.1/datapackage.json and 2.1/dataresource.json since it's not a property of those specs. 🤔

Good that this will get merged with next

@roll
Copy link
Member Author

roll commented Sep 25, 2024

Thanks!

I don't understand why fieldsMatch appears in 2.1/datapackage.json and 2.1/dataresource.json since it's not a property of those specs.

It's because one Data Package (or Resource) JSON Schema has to cover bot non-tabular and tabular resource.

@roll roll merged commit 60663f8 into next Sep 25, 2024
1 check passed
@roll roll deleted the 975/fix-schema-fields-match branch September 25, 2024 07:35
roll added a commit that referenced this pull request Oct 22, 2024
@roll @peterdesmet
Fixed schema.fieldsMatch (#981)
a3cac2c 
* Fixed `schema.fieldsMatch`

* Rephrase cf. rest of Changelog

---------

Co-authored-by: Peter Desmet <[email protected]>
@roll roll mentioned this pull request Oct 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdesmet peterdesmet peterdesmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roll @peterdesmet